[
https://issues.apache.org/jira/browse/CURATOR-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033407#comment-14033407
]
ASF GitHub Bot commented on CURATOR-114:
----------------------------------------
GitHub user cammckenzie opened a pull request:
https://github.com/apache/curator/pull/11
CURATOR-114 - Modified the TestingServer to expose the restart() method
Modified the TestingServer to expose the restart() method on the underlying
TestingZooKeeperServer. Modified all unit tests that were previously using the
stop() and then recreate using existing temporary directory and port approach
for restarting the server, so that they now just call the restart() method.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cammckenzie/curator CURATOR-114
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/11.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11
----
commit 27c70aab9a3d86ba9a8a20e3ae28ef5bed147300
Author: Cameron McKenzie <[email protected]>
Date: 2014-06-17T03:49:03Z
CURATOR-114 - Modified the TestingServer to expose the restart() method
on the underlying TestingZooKeeperServer. Modified all unit tests that
were previously using the stop() and then recreate using existing
temporary directory and port approach for restarting the server, so that
they now just call the restart() method.
----
> TestingServer should expose restart() method.
> ---------------------------------------------
>
> Key: CURATOR-114
> URL: https://issues.apache.org/jira/browse/CURATOR-114
> Project: Apache Curator
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 2.5.0
> Reporter: Cameron McKenzie
> Priority: Trivial
>
> Currently restarting the TestingServer involves:
> server.stop()
> server = new TestingServer(server.getPort(), server.getTempDirectory());
> The underlying Zookeeper testing server that is contained within
> TestingServer supports a restart() method. It would be cleaner to expose this
> on the TestingServer interface, so a restart would simply involve:
> server.restart()
--
This message was sent by Atlassian JIRA
(v6.2#6252)
