[
https://issues.apache.org/jira/browse/CURATOR-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034408#comment-14034408
]
ASF GitHub Bot commented on CURATOR-114:
----------------------------------------
Github user madrob commented on a diff in the pull request:
https://github.com/apache/curator/pull/11#discussion_r13886987
--- Diff:
curator-test/src/main/java/org/apache/curator/test/TestingServer.java ---
@@ -104,6 +171,17 @@ public void stop() throws IOException
}
/**
+ * Restart the server. This is only valid if the server has previously
been
--- End diff --
As a user, it would make sense for restart to work from any state. My
mental model is akin to Unix services where restart is simply "stop ; start"
> TestingServer should expose restart() method.
> ---------------------------------------------
>
> Key: CURATOR-114
> URL: https://issues.apache.org/jira/browse/CURATOR-114
> Project: Apache Curator
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 2.5.0
> Reporter: Cameron McKenzie
> Priority: Trivial
>
> Currently restarting the TestingServer involves:
> server.stop()
> server = new TestingServer(server.getPort(), server.getTempDirectory());
> The underlying Zookeeper testing server that is contained within
> TestingServer supports a restart() method. It would be cleaner to expose this
> on the TestingServer interface, so a restart would simply involve:
> server.restart()
--
This message was sent by Atlassian JIRA
(v6.2#6252)
