[
https://issues.apache.org/jira/browse/CURATOR-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177023#comment-14177023
]
ASF GitHub Bot commented on CURATOR-145:
----------------------------------------
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/42#discussion_r19093513
--- Diff:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCache.java
---
@@ -179,24 +191,34 @@ public static Builder newBuilder(CuratorFramework
client, String path)
final AtomicReference<Stat> stat = new AtomicReference<Stat>();
final AtomicReference<byte[]> data = new AtomicReference<byte[]>();
final AtomicReference<ConcurrentMap<String, TreeNode>> children =
new AtomicReference<ConcurrentMap<String, TreeNode>>();
+ final int depth;
TreeNode(String path, TreeNode parent)
{
this.path = path;
this.parent = parent;
+ this.depth = parent == null ? 0 : parent.depth + 1;
}
private void refresh() throws Exception
{
- outstandingOps.addAndGet(2);
- doRefreshData();
- doRefreshChildren();
+ if (depth < maxDepth)
--- End diff --
This is an interesting idea. We could leave the integer based maxDepth in
the builder but have it create a Predicate internally. Then, have an alternate
method in the builder that takes an actual predicate. But, let's let
@dragonsinth decide.
> TreeCache should implement maxDepth
> -----------------------------------
>
> Key: CURATOR-145
> URL: https://issues.apache.org/jira/browse/CURATOR-145
> Project: Apache Curator
> Issue Type: Improvement
> Components: Recipes
> Reporter: Scott Blum
> Original Estimate: 48h
> Remaining Estimate: 48h
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
