[ 
https://issues.apache.org/jira/browse/CURATOR-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177399#comment-14177399
 ] 

ASF GitHub Bot commented on CURATOR-145:
----------------------------------------

Github user dragonsinth commented on the pull request:

    https://github.com/apache/curator/pull/42#issuecomment-59829735
  
    I'm inclined to want to go with what we have and reserve Predicate as a 
future feature.  I don't think anything here so far would make it harder / 
preclude adding it later.
    
    I have 2 main concerns over adding general Predicates that make me want to 
consider this much more carefully.
    
    1) Running the predicate means passing control to user code on cache's 
event callback / mutation threads.
    2) An inconsistent predicate would be super weird and possibly corrupt 
internal state.  What would happen if a predicate's behavior changed on the 
fly, or gave inconsistent answers for the same node?
    
    The idea definitely has merit I'm just not really ready to take it on right 
now.


> TreeCache should implement maxDepth
> -----------------------------------
>
>                 Key: CURATOR-145
>                 URL: https://issues.apache.org/jira/browse/CURATOR-145
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Recipes
>            Reporter: Scott Blum
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to