[
https://issues.apache.org/jira/browse/CURATOR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499185#comment-14499185
]
ASF GitHub Bot commented on CURATOR-164:
----------------------------------------
Github user busbey commented on a diff in the pull request:
https://github.com/apache/curator/pull/72#discussion_r28567933
--- Diff:
curator-x-discovery/src/test/java/org/apache/curator/x/discovery/TestServiceDiscovery.java
---
@@ -297,4 +304,70 @@ public void testNoServerOnStart() throws Exception
}
}
}
+
+ // CURATOR-164
+ @Test
+ public void testUnregisterService() throws Exception {
+ final String name = "name";
+
+ final CountDownLatch restartLatch = new CountDownLatch(1);
+ final CountDownLatch serializeLatch = new CountDownLatch(1);
--- End diff --
you made this latch, but then used a sleep call to wait for the
serialization to finish. better ot switch to using this latch.
> curator-x-discovery: unregisterService is not guaranteed to remove the
> service, due to reconnectListener concurrency issue
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: CURATOR-164
> URL: https://issues.apache.org/jira/browse/CURATOR-164
> Project: Apache Curator
> Issue Type: Bug
> Components: Framework
> Affects Versions: 2.7.0
> Reporter: Rasmus Berg Palm
> Priority: Critical
>
> In ServiceDiscoveryImpl:
> When unregistering a service, the reconnect listener might fire while
> deleting the path.
> This can cause a condition where the delete finishes successfully, the
> service is removed from services, and then the reRegisterServices completes
> successfully and the service is added back in ZK and in services, end result
> being that the service was not removed, even though unregisterService did not
> throw any exceptions.
> Essentially the use of the internal 'services' cache makes for a nightmare of
> concurrency issues. I put this as critical as the library it's really not
> usable IMO.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
