Github user cammckenzie commented on a diff in the pull request:
https://github.com/apache/curator/pull/186#discussion_r95088443
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java
---
@@ -485,7 +485,6 @@ private String protectedPathInForeground(String
adjustedPath, byte[] data) throw
}
catch ( Exception e)
{
- ThreadUtils.checkInterrupted(e);
--- End diff --
Won't the removal of this call mean that the thread will not be marked as
interrupted unless the caller catches the exception and resets the value
themselves? This code is called from many recipes and can also be called
explicitly by users Curator code. I would think that there's great potential to
break code here, unless I'm missing something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
