Github user thecoop commented on a diff in the pull request:

    https://github.com/apache/curator/pull/186#discussion_r95382951
  
    --- Diff: 
curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java
 ---
    @@ -485,7 +485,6 @@ private String protectedPathInForeground(String 
adjustedPath, byte[] data) throw
             }
             catch ( Exception e)
             {
    -            ThreadUtils.checkInterrupted(e);
    --- End diff --
    
    No, because the `InterruptedException` is rethrown in every case. Thread 
interruption status is represented by _either_ the thread interrupt status _or_ 
an `InterruptedException`, not both. This is mentioned in the Java tutorials at 
http://docs.oracle.com/javase/tutorial/essential/concurrency/interrupt.html:
    
    > By convention, any method that exits by throwing an InterruptedException 
clears interrupt status when it does so. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to