Github user cammckenzie commented on a diff in the pull request:
https://github.com/apache/curator/pull/197#discussion_r98367367
--- Diff:
curator-client/src/main/java/org/apache/curator/ConnectionState.java ---
@@ -160,13 +162,33 @@ public void process(WatchedEvent event)
}
}
+ // only wait during tests
+ assert waitOnExpiredEvent(event.getState());
--- End diff --
How is this meant to work? Are you assuming that assertions will only be
enabled in testing? If you need some logic to only be executed during testing
shouldn't there be some sort of internal flag indicating this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
