Github user Zoltan-Szekeres commented on a diff in the pull request:

    https://github.com/apache/curator/pull/197#discussion_r98421892
  
    --- Diff: 
curator-client/src/main/java/org/apache/curator/ConnectionState.java ---
    @@ -160,13 +162,33 @@ public void process(WatchedEvent event)
                 }
             }
     
    +        // only wait during tests
    +        assert waitOnExpiredEvent(event.getState());
    +
             for ( Watcher parentWatcher : parentWatchers )
             {
    -
                 OperationTrace trace = new 
OperationTrace("connection-state-parent-process", tracer.get(), getSessionId());
                 parentWatcher.process(event);
                 trace.commit();
             }
    +
    +        if (eventTypeNone) handleState(event.getState());
    +    }
    +
    +    // only for testing
    +    private boolean waitOnExpiredEvent(Event.KeeperState currentState)
    --- End diff --
    
    Yes - only so that it can be called form assert.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to