[
https://issues.apache.org/jira/browse/CURATOR-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979303#comment-15979303
]
ASF GitHub Bot commented on CURATOR-106:
----------------------------------------
GitHub user srdo opened a pull request:
https://github.com/apache/curator/pull/215
CURATOR-106: Ensure background operations happen in the background thread
to avoid stack overflows when retrying guaranteed operations
See
https://issues.apache.org/jira/browse/CURATOR-106?focusedCommentId=15979112&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15979112
Also a few tests in TestNamespaceFacade were not passing because they were
using blank connect strings. I'd be happy to open a separate issue for that
change if necessary, or remove it if I misunderstood the tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/curator CURATOR-106
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/215.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #215
----
commit 2422c2be094835e84161919b3fee5e4c872d4397
Author: Stig Rohde Døssing <[email protected]>
Date: 2017-04-21T20:03:27Z
CURATOR-106: Ensure background operations happen in the background thread
to avoid stack overflows when retrying guaranteed operations
commit e7bf733d91460117d19958221b4902f4b99efb2e
Author: Stig Rohde Døssing <[email protected]>
Date: 2017-04-21T20:03:58Z
CURATOR-106: Fix flaky unit test
----
> Issuing a guaranteed delete can cause stack overflow if ZK is not reachable
> ---------------------------------------------------------------------------
>
> Key: CURATOR-106
> URL: https://issues.apache.org/jira/browse/CURATOR-106
> Project: Apache Curator
> Issue Type: Bug
> Components: Framework
> Affects Versions: 2.4.2
> Reporter: Jasdeep Hundal
> Fix For: awaiting-response
>
>
> For guaranteed deletes (eg. lock releases) that fail, the FailedDeleteManager
> issues another guaranteed delete here:
> https://github.com/apache/curator/blob/master/curator-framework/src/main/java/org/apache/curator/framework/imps/FailedDeleteManager.java#L35
> In an environment where ZK has the potential to be down for an extended
> period of time, this has the potential to recurse until there is a stack
> overflow (particularly if the application is using multiple locks.)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
