[
https://issues.apache.org/jira/browse/CURATOR-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027843#comment-16027843
]
ASF GitHub Bot commented on CURATOR-106:
----------------------------------------
Github user Randgalt commented on the issue:
https://github.com/apache/curator/pull/215
@srdo I've looked at this again more deeply and I stand by my original
comment. This code:
```java
boolean isInitialExecution = (event == null);
if (isInitialExecution) {
queueOperation(operationAndData);
return;
}
```
Breaks a vital contract. `queueOperation` will add the operation to
`backgroundOperations` which are handled by CuratorFrameworkImpl's
`executorService`. So, we cannot accept this PR. I'm going to close it unless
you can think of a way of solving the original problem differently. I'll look
at CURATOR-106 when I can to see if I can understand the issue.
> Issuing a guaranteed delete can cause stack overflow if ZK is not reachable
> ---------------------------------------------------------------------------
>
> Key: CURATOR-106
> URL: https://issues.apache.org/jira/browse/CURATOR-106
> Project: Apache Curator
> Issue Type: Bug
> Components: Framework
> Affects Versions: 2.4.2
> Reporter: Jasdeep Hundal
> Fix For: awaiting-response
>
>
> For guaranteed deletes (eg. lock releases) that fail, the FailedDeleteManager
> issues another guaranteed delete here:
> https://github.com/apache/curator/blob/master/curator-framework/src/main/java/org/apache/curator/framework/imps/FailedDeleteManager.java#L35
> In an environment where ZK has the potential to be down for an extended
> period of time, this has the potential to recurse until there is a stack
> overflow (particularly if the application is using multiple locks.)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
