Here's the PR. I'll send a note to both @dev and @user https://github.com/apache/curator/pull/233 <https://github.com/apache/curator/pull/233>
-Jordan > On Jul 23, 2017, at 11:54 PM, Jordan Zimmerman <[email protected]> > wrote: > > I have no way of knowing. But, this is 4.0 after all - a major version bump. > I've canceled the vote for now. I'll create a PR with the change and we can > discuss it there. > > -JZ >> On Jul 23, 2017, at 11:46 PM, Cameron McKenzie <[email protected] >> <mailto:[email protected]>> wrote: >> >> I think that approach is probably reasonable, but it would be nice to know >> if anyone is actually using the classic handling. >> >> On Mon, Jul 24, 2017 at 2:21 PM, Jordan Zimmerman < >> [email protected] <mailto:[email protected]>> wrote: >> >>> I wonder if we shouldn't just deprecate "classic" connection handling >>> since we're going to 4.0 anyway. It would certainly make the tests faster >>> and I can't imagine anyone is using it. But who knows. Thoughts? >>> >>> -Jordan >>> >>>> On Jul 23, 2017, at 8:26 PM, Cameron McKenzie <[email protected] >>>> <mailto:[email protected]>> >>> wrote: >>>> >>>> The TestTreeCache tests seem to be failing consistently for me >>>> >>>> Specifically, the tests run OK but the teardown method is failing: >>>> >>>> java.lang.AssertionError: Expected no events, found 2; first event: >>>> TreeCacheEvent{type=CONNECTION_LOST, data=null} expected [true] but >>> found >>>> [false] >>>> at org.testng.Assert.fail(Assert.java:94) >>>> at org.testng.Assert.failNotEquals(Assert.java:496) >>>> at org.testng.Assert.assertTrue(Assert.java:42) >>>> at >>>> org.apache.curator.framework.recipes.cache.BaseTestTreeCache. >>> assertNoMoreEvents(BaseTestTreeCache.java:143) >>>> at >>>> org.apache.curator.framework.recipes.cache.BaseTestTreeCache.teardown( >>> BaseTestTreeCache.java:123) >>>> at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source) >>>> at >>>> sun.reflect.DelegatingMethodAccessorImpl.invoke( >>> DelegatingMethodAccessorImpl.java:43) >>>> at java.lang.reflect.Method.invoke(Method.java:606) >>>> at >>>> org.testng.internal.MethodInvocationHelper.invokeMethod( >>> MethodInvocationHelper.java:85) >>>> at org.testng.internal.Invoker.in >>>> <http://org.testng.internal.invoker.in/>vokeConfigurationMethod( >>> Invoker.java:515) >>>> at org.testng.internal.Invoker.in >>>> <http://org.testng.internal.invoker.in/>vokeConfigurations(Invoker.java:213) >>>> at org.testng.internal.Invoker.in >>>> <http://org.testng.internal.invoker.in/>vokeMethod(Invoker.java:721) >>>> at org.testng.internal.Invoker.in >>>> <http://org.testng.internal.invoker.in/>vokeTestMethod(Invoker.java:834) >>>> at org.testng.internal.Invoker.in >>>> <http://org.testng.internal.invoker.in/>vokeTestMethods(Invoker.java:1142) >>>> at >>>> org.testng.internal.TestMethodWorker.invokeTestMethods( >>> TestMethodWorker.java:124) >>>> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:108) >>>> at org.testng.TestRunner.privateRun(TestRunner.java:771) >>>> at org.testng.TestRunner.run(TestRunner.java:621) >>>> at org.testng.SuiteRunner.runTest(SuiteRunner.java:357) >>>> at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:352) >>>> at org.testng.SuiteRunner.privateRun(SuiteRunner.java:310) >>>> at org.testng.SuiteRunner.run(SuiteRunner.java:259) >>>> at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52) >>>> at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86) >>>> at org.testng.TestNG.runSuitesSequentially(TestNG.java:1176) >>>> at org.testng.TestNG.runSuitesLocally(TestNG.java:1101) >>>> at org.testng.TestNG.run(TestNG.java:1009) >>>> at org.testng.remote.RemoteTestNG.run(RemoteTestNG.java:111) >>>> at org.testng.remote.RemoteTestNG.initAndRun(RemoteTestNG.java:204) >>>> at org.testng.remote.RemoteTestNG.main(RemoteTestNG.java:175) >>>> >>>> >>>> >>>> On Mon, Jul 24, 2017 at 5:27 AM, Jordan Zimmerman <[email protected] >>>> <mailto:[email protected]>> >>>> wrote: >>>> >>>>> Hello, >>>>> >>>>> This is the vote for Apache Curator version 4.0.0 - candidate 2 >>>>> >>>>> *** Please download, test and vote within approx. 72 hours >>>>> >>>>> Note that we are voting upon the source (tag) and binaries are provided >>> for >>>>> convenience. >>>>> >>>>> Link to release notes: >>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje >>>>> <https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje> >>>>> ctId=12314425&version=12339847 >>>>> >>>>> Staging repo: >>>>> https://dist.apache.org/repos/dist/dev/curator/4.0.0/ >>>>> <https://dist.apache.org/repos/dist/dev/curator/4.0.0/> >>>>> >>>>> Binary artifacts: >>>>> https://repository.apache.org/content/repositories/ >>>>> <https://repository.apache.org/content/repositories/> >>> orgapachecurator-1041/ >>>>> >>>>> Stage Website: >>>>> http://curator.apache.org/private/staging/ >>>>> <http://curator.apache.org/private/staging/> >>>>> >>>>> The tag to be voted upon: >>>>> https://git-wip-us.apache.org/repos/asf?p=curator.git;a=tag >>>>> <https://git-wip-us.apache.org/repos/asf?p=curator.git;a=tag>; >>>>> h=dd153164948d3ebd5fa5506f2a5e47c24cf1e191 >>>>> >>>>> Curator's KEYS file containing PGP keys we use to sign the release: >>>>> http://www.apache.org/dist/curator/KEYS >>>>> <http://www.apache.org/dist/curator/KEYS> >>>>> >>>>> [ ] +1 approve >>>>> [ ] +0 no opinion >>>>> [ ] -1 disapprove (and reason why) >>>>> >>> >>> >
