I was able to get a clean passing run after several attempts but they definitely fail 9 out of 10 times on my laptop... IIRC I didn't see the problem nearly as much on my desktop. Both OSX.
On Fri, Jul 28, 2017 at 7:23 AM, Jordan Zimmerman < [email protected]> wrote: > Oops - the maven command is: > > mvn -Dtest=TestReconfiguration -DfailIfNoTests=false test > > On Jul 28, 2017, at 9:07 AM, Jordan Zimmerman <[email protected]> > wrote: > > I just ran TestReconfiguration and it worked for me. Maybe you can re-rest > just that. In Maven: > > mvn -Dtest=TestReconfiguration test > > In any event - this test appears to be flakey. Does anyone think it should > hold up the release? My feeling is that it's OK to release acknowledging > this is a flakey test. > > -JZ > > On Jul 27, 2017, at 11:02 PM, Fangmin Lv <[email protected]> wrote: > > Run the tests again, and see TestReconfiguration failed: > > Tests run: 15, Failures: 2, Errors: 0, Skipped: 2, Time elapsed: 67.822 > sec <<< FAILURE! - in org.apache.curator.framework. > imps.TestReconfiguration > testAdd(org.apache.curator.framework.imps.TestReconfiguration) Time > elapsed: 12.941 sec <<< FAILURE! > org.apache.zookeeper.KeeperException$BadVersionException: KeeperErrorCode > = BadVersion > at org.apache.curator.framework.imps.TestReconfiguration. > testAdd(TestReconfiguration.java:195) > > testAddAndRemove(org.apache.curator.framework.imps.TestReconfiguration) > Time elapsed: 12.884 sec <<< FAILURE! > org.apache.zookeeper.KeeperException$BadVersionException: KeeperErrorCode > = BadVersion > at org.apache.curator.framework.imps.TestReconfiguration.testAddAndRemove( > TestReconfiguration.java:277) > > Anyone else has this issue or only me? > > On Thu, Jul 27, 2017 at 8:55 PM, Fangmin Lv <[email protected]> wrote: > >> +1 >> >> Same here, all tests passed except the ZK3.4 compatibility testing shows >> error. >> >> On Thu, Jul 27, 2017 at 8:39 PM, Scott Blum <[email protected]> >> wrote: >> >>> It looks like clirr-maven-plugin needs some configuration love as far as >>> what is actually part of the Curator public SDK. >>> >>> [INFO] --- clirr-maven-plugin:2.8:check (default) @ curator-client --- >>> [INFO] artifact org.apache.curator:curator-client: checking for updates >>> from central >>> [INFO] Comparing to version: 3.3.0 >>> [ERROR] 8001: >>> org.apache.curator.connection.ClassicConnectionHandlingPolicy: Class >>> org.apache.curator.connection.ClassicConnectionHandlingPolicy removed >>> [ERROR] 8001: org.apache.curator.shaded.com. >>> google.common.annotations.Beta: >>> Class org.apache.curator.shaded.com.google.common.annotations.Beta >>> removed >>> >>> Running tests now >>> >>> On Thu, Jul 27, 2017 at 10:48 PM, Jordan Zimmerman < >>> [email protected]> wrote: >>> >>> > Ok. It's just hard to get the votes. Can I convince you to just clone >>> and >>> > do a mvn test? You can run it in the background. >>> > >>> > ==================== >>> > Jordan Zimmerman >>> > >>> > On Jul 27, 2017, at 9:03 PM, Scott Blum <[email protected]> wrote: >>> > >>> > Same as always! I don't have the bandwidth to actively monitor >>> Curator, >>> > test it myself, or try out a new version against a code base I work on >>> that >>> > uses it. So I can't vouch for it, but I trust you guys. >>> > >>> > On Thu, Jul 27, 2017 at 6:28 PM, Jordan Zimmerman < >>> > [email protected]> wrote: >>> > >>> >> What's the reason for +0 Scott? >>> >> >>> >> > On Jul 27, 2017, at 3:55 PM, Scott Blum <[email protected]> >>> wrote: >>> >> > >>> >> > +0 >>> >> > >>> >> > On Wed, Jul 26, 2017 at 7:42 PM, Jordan Zimmerman < >>> >> > [email protected]> wrote: >>> >> > >>> >> >>> All the tests are passing\ >>> >> >> In 40 min for which is a huge difference. >>> >> >> >>> >> >>> (though the actual Maven task for the ZK3.4 >>> >> >>> compatibility testing fails after all of the tests pass). >>> >> >> >>> >> >> Yeah = there's some weirdness with the way I'm copying in those >>> files. >>> >> >> Let's make that a TBB. >>> >> >> >>> >> >>> On Jul 26, 2017, at 6:41 PM, Cameron McKenzie < >>> [email protected] >>> >> > >>> >> >> wrote: >>> >> >>> >>> >> >>> +1 from me >>> >> >>> >>> >> >>> All the tests are passing (though the actual Maven task for the >>> ZK3.4 >>> >> >>> compatibility testing fails after all of the tests pass). >>> >> >>> Signatures are ok. >>> >> >>> >>> >> >>> >>> >> >>> On Thu, Jul 27, 2017 at 12:19 AM, Jordan Zimmerman < >>> >> [email protected]> >>> >> >>> wrote: >>> >> >>> >>> >> >>>> Hello, >>> >> >>>> >>> >> >>>> This is the vote for Apache Curator version 4.0.0 - candidate 3 >>> >> >>>> >>> >> >>>> *** Please download, test and vote within approx. 72 hours >>> >> >>>> >>> >> >>>> http://datecountdown.com/?&d=7%2f29%2f2017+9%3a00+AM&t= >>> >> >>>> Apache+Curator+4.0.0+Release >>> >> >>>> >>> >> >>>> Note that we are voting upon the source (tag) and binaries are >>> >> provided >>> >> >> for >>> >> >>>> convenience. >>> >> >>>> >>> >> >>>> Link to release notes: >>> >> >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa? >>> >> >>>> projectId=12314425&version=12339847 >>> >> >>>> >>> >> >>>> Staging repo: >>> >> >>>> https://dist.apache.org/repos/dist/dev/curator/4.0.0/ >>> >> >>>> >>> >> >>>> Binary artifacts: >>> >> >>>> https://repository.apache.org/content/repositories/ >>> >> >> orgapachecurator-1042/ >>> >> >>>> >>> >> >>>> Stage Website: >>> >> >>>> http://curator.apache.org/private/staging/ >>> >> >>>> >>> >> >>>> The tag to be voted upon: >>> >> >>>> https://git-wip-us.apache.org/repos/asf?p=curator.git;a=tag;h= >>> >> >>>> aba918d2e6f325e6f4077e173feee26e93876a23 >>> >> >>>> >>> >> >>>> Curator's KEYS file containing PGP keys we use to sign the >>> release: >>> >> >>>> http://www.apache.org/dist/curator/KEYS >>> >> >>>> >>> >> >>>> [ ] +1 approve >>> >> >>>> [ ] +0 no opinion >>> >> >>>> [ ] -1 disapprove (and reason why) >>> >> >>>> >>> >> >> >>> >> >> >>> >> >>> >> >>> > >>> >> >> > > >
