Github user cammckenzie commented on the issue:

    https://github.com/apache/curator/pull/262
  
    Thanks for the updates, I think this looks good.
    
    I still think we need to look at the default behaviour of the 
ConnectionStateListener though. Currently, a LOST event will only be injected 
after 4/3 of the session timeout (+ some small error). I think that this 
default behaviour should be changed so that the LOST event is injected at 
session timeout (+ some small error). This could be achieved by either changing 
the StandardConnectionHandlingPolicy default constructor to use 66 instead of 
100 for the %, or by changing the ConnectionStateListener logic. I think it's 
probably simpler to change via the StandardConnectionHandlingPolicy, because 
the ConnectionStateListener logic interacts with the % defined in the 
StandardConnectionHandlingPolicy and has more potential to break existing use 
cases.
    
    What are your thoughts @Randgalt ?


---

Reply via email to