[
https://issues.apache.org/jira/browse/CURATOR-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714142#comment-16714142
]
ASF GitHub Bot commented on CURATOR-479:
----------------------------------------
GitHub user Randgalt opened a pull request:
https://github.com/apache/curator/pull/294
[CURATOR-479] fixed CachedModeledFrameworkImpl children
Added new method to ZPath, isParentOf(). The, use it in
CachedModeledFrameworkImpl.children() and
CachedModeledFrameworkImpl.childrenAsZNodes() which were not implemented
correctly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/curator CURATOR-479
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/294.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #294
----
commit 1429676ea43ecfbfe3dd7f28f222d58105e41d3f
Author: Hendrik Haddorp <hendrik.haddorp@...>
Date: 2018-12-08T20:42:11Z
fixed CachedModeledFrameworkImpl children queries,
https://issues.apache.org/jira/browse/CURATOR-479
commit a0f5f6eccbbc7483bf4a9b9165e0ea8d64c3999b
Author: randgalt <randgalt@...>
Date: 2018-12-09T22:07:54Z
Merge branch 'CURATOR-479' of github.com:Hendrik-H/curator into CURATOR-479
commit 81878339179595c304d7efce4450807b218839be
Author: randgalt <randgalt@...>
Date: 2018-12-09T22:46:12Z
CURATOR-479
Added new method to ZPath, isParentOf(). The, use it in
CachedModeledFrameworkImpl.children() and
CachedModeledFrameworkImpl.childrenAsZNodes() which were not implemented
correctly.
----
> org.apache.curator.x.async.modeled.details.CachedModeledFrameworkImpl.children()
> does not work
> ----------------------------------------------------------------------------------------------
>
> Key: CURATOR-479
> URL: https://issues.apache.org/jira/browse/CURATOR-479
> Project: Apache Curator
> Issue Type: Bug
> Affects Versions: 4.0.1
> Reporter: Hendrik Haddorp
> Assignee: Jordan Zimmerman
> Priority: Major
>
> org.apache.curator.x.async.modeled.details.CachedModeledFrameworkImpl.children()
> and
> org.apache.curator.x.async.modeled.details.CachedModeledFrameworkImpl.childrenAsZNodes()
> do not seem to work. This filter condition looks wrong to me:
> .filter(path -> path.equals(cache.basePath()))
> Getting the children on an uncached model works just fine but on a cached
> model I always get an empty list. The list that
> cache.currentChildren(client.modelSpec().path()) returns within the methods
> looks correct but then there is this strange additional path filtering that
> throws away everything.
> The test code for that class seems to be in
> https://github.com/apache/curator/blob/master/curator-x-async/src/test/java/org/apache/curator/x/async/modeled/TestCachedModeledFramework.java.
> Looks like the children calls are not tested.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
