[
https://issues.apache.org/jira/browse/CURATOR-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715523#comment-16715523
]
ASF GitHub Bot commented on CURATOR-479:
----------------------------------------
GitHub user Randgalt opened a pull request:
https://github.com/apache/curator/pull/296
CURATOR-479 - CachedModeledFrameworkImpl.children() and
CachedModeledFrameworkImpl.childrenAsZNodes() were not implemented correctly
CachedModeledFrameworkImpl.children() and
CachedModeledFrameworkImpl.childrenAsZNodes() were not implemented correctly
but neither was the previous commit for this. This is the correct fix. Previous
commit was returning full tree, should be 1 level only
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/curator CURATOR-479-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/296.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #296
----
commit 273832442298b9d8779c1eb64d881ebd668fee8b
Author: randgalt <randgalt@...>
Date: 2018-12-10T20:40:46Z
CURATOR-479
CachedModeledFrameworkImpl.children() and
CachedModeledFrameworkImpl.childrenAsZNodes() were not implemented correctly
but neither was the previous commit for this. This is the correct fix. Previous
commit was returning full tree, should be 1 level only
----
> org.apache.curator.x.async.modeled.details.CachedModeledFrameworkImpl.children()
> does not work
> ----------------------------------------------------------------------------------------------
>
> Key: CURATOR-479
> URL: https://issues.apache.org/jira/browse/CURATOR-479
> Project: Apache Curator
> Issue Type: Bug
> Affects Versions: 4.0.1
> Reporter: Hendrik Haddorp
> Assignee: Jordan Zimmerman
> Priority: Major
> Fix For: 4.1.0
>
>
> org.apache.curator.x.async.modeled.details.CachedModeledFrameworkImpl.children()
> and
> org.apache.curator.x.async.modeled.details.CachedModeledFrameworkImpl.childrenAsZNodes()
> do not seem to work. This filter condition looks wrong to me:
> .filter(path -> path.equals(cache.basePath()))
> Getting the children on an uncached model works just fine but on a cached
> model I always get an empty list. The list that
> cache.currentChildren(client.modelSpec().path()) returns within the methods
> looks correct but then there is this strange additional path filtering that
> throws away everything.
> The test code for that class seems to be in
> https://github.com/apache/curator/blob/master/curator-x-async/src/test/java/org/apache/curator/x/async/modeled/TestCachedModeledFramework.java.
> Looks like the children calls are not tested.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
