Github user cammckenzie commented on a diff in the pull request:
https://github.com/apache/curator/pull/303#discussion_r251672915
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java
---
@@ -48,19 +50,21 @@
public class CreateBuilderImpl implements CreateBuilder, CreateBuilder2,
BackgroundOperation<PathAndBytes>, ErrorListenerPathAndBytesable<String>
{
+ private final Logger log = LoggerFactory.getLogger(getClass());
private final CuratorFrameworkImpl client;
private CreateMode createMode;
private Backgrounding backgrounding;
private boolean createParentsIfNeeded;
private boolean createParentsAsContainers;
- private boolean doProtected;
private boolean compress;
private boolean setDataIfExists;
private int setDataIfExistsVersion = -1;
- private String protectedId;
private ACLing acling;
private Stat storingStat;
private long ttl;
+ private boolean doProtected;
+ private String protectedId;
+ private long initialSessionId;
--- End diff --
I think that maybe the initialSessionId should have a different name as
it's a bit misleading. It's not really the initialSessionId as it gets updated
during the edge case for handling protected ephemeral nodes. Really, it's the
session ID at the time of creation for a protected ephemeral node isn't it?
Perhaps it should be named accordingly and only initialised for the case where
it will be needed?
---
