Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/303#discussion_r251851979
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java
---
@@ -610,18 +610,18 @@ private String protectedPathInForeground(String
adjustedPath, byte[] data, List<
{
ThreadUtils.checkInterrupted(e);
if ( ( e instanceof KeeperException.ConnectionLossException ||
- !( e instanceof KeeperException )) && protectedId != null )
+ !( e instanceof KeeperException )) &&
protectedMode.doProtected() )
--- End diff --
Note: this is a subtle change. The previous version checked `protectedId
!= null` and I don't remember why.
---
