[
https://issues.apache.org/jira/browse/CURATOR-549?focusedWorklogId=341092&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341092
]
ASF GitHub Bot logged work on CURATOR-549:
------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Nov/19 21:01
Start Date: 10/Nov/19 21:01
Worklog Time Spent: 10m
Work Description: shayshim commented on pull request #338: [CURATOR-549]
Prep for Persistent Watchers by moving to ZK 3.6.0
URL: https://github.com/apache/curator/pull/338#discussion_r344514913
##########
File path:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
##########
@@ -620,6 +621,15 @@ ZooKeeper getZooKeeper() throws Exception
return client.getZooKeeper();
}
+ Object getZooKeeperAdmin() throws Exception
Review comment:
If we return client.getZooKeeper(), just like in getZooKeeper(), then this
method seems unneeded to me. Clients should call getZooKeeper() and cast to
ZooKeeperAdmin if they need (like in ReconfigBuilderImpl).
You also could promise in its javadoc to return ZooKeeperAdmin for versions
3.5 and up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 341092)
Time Spent: 1h 50m (was: 1h 40m)
> ZooKeeper 3.6 will add support for Persistent Recursive Watchers - Add
> Curator support
> --------------------------------------------------------------------------------------
>
> Key: CURATOR-549
> URL: https://issues.apache.org/jira/browse/CURATOR-549
> Project: Apache Curator
> Issue Type: Improvement
> Components: Client, Documentation, Framework, Recipes, Tests
> Affects Versions: 4.2.0
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Priority: Major
> Fix For: 4.3.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> ZOOKEEPER-1416 will add support for Persistent Recursive Watchers. This
> feature allows Curator to re-think/re-write the various cache recipes so that
> they're simpler, use less resources and more stable.
> * Change Curator to depend on ZooKeeper 3.6.x
> * Add a new module so that backward compatibility with 3.5 is ensured
> * Add new methods corresponding to {{ZooKeeper.addWatch()}}
> * Add a new recipe that enables a fully managed Persistent watch
> * Create new Cache recipes that use the new Persistent watch recipe
> * Replace internal usages of TreeCache/PathChildrenCache/NodeCache with new
> cache recipe
> * Deprecate TreeCache/PathChildrenCache/NodeCache
> * Updated docs/tests/etc
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
