[
https://issues.apache.org/jira/browse/CURATOR-549?focusedWorklogId=341099&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341099
]
ASF GitHub Bot logged work on CURATOR-549:
------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Nov/19 21:36
Start Date: 10/Nov/19 21:36
Worklog Time Spent: 10m
Work Description: shayshim commented on pull request #338: [CURATOR-549]
Prep for Persistent Watchers by moving to ZK 3.6.0
URL: https://github.com/apache/curator/pull/338#discussion_r344516443
##########
File path:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorMultiTransactionRecord.java
##########
@@ -16,49 +16,57 @@
* specific language governing permissions and limitations
* under the License.
*/
+
package org.apache.curator.framework.imps;
import com.google.common.collect.Lists;
import org.apache.curator.framework.api.transaction.OperationType;
import org.apache.curator.framework.api.transaction.TypeAndPath;
-import org.apache.zookeeper.MultiTransactionRecord;
import org.apache.zookeeper.Op;
import java.security.MessageDigest;
+import java.util.ArrayList;
+import java.util.Iterator;
import java.util.List;
-class CuratorMultiTransactionRecord extends MultiTransactionRecord
+class CuratorMultiTransactionRecord implements Iterable<Op>
{
- private final List<TypeAndPath> metadata = Lists.newArrayList();
-
- @Override
- public final void add(Op op)
- {
- throw new UnsupportedOperationException();
- }
+ private final List<TypeAndPath> metadata = Lists.newArrayList();
+ private List<Op> ops = new ArrayList<>();
Review comment:
Can be final too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 341099)
Time Spent: 2h 50m (was: 2h 40m)
> ZooKeeper 3.6 will add support for Persistent Recursive Watchers - Add
> Curator support
> --------------------------------------------------------------------------------------
>
> Key: CURATOR-549
> URL: https://issues.apache.org/jira/browse/CURATOR-549
> Project: Apache Curator
> Issue Type: Improvement
> Components: Client, Documentation, Framework, Recipes, Tests
> Affects Versions: 4.2.0
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Priority: Major
> Fix For: 4.3.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> ZOOKEEPER-1416 will add support for Persistent Recursive Watchers. This
> feature allows Curator to re-think/re-write the various cache recipes so that
> they're simpler, use less resources and more stable.
> * Change Curator to depend on ZooKeeper 3.6.x
> * Add a new module so that backward compatibility with 3.5 is ensured
> * Add new methods corresponding to {{ZooKeeper.addWatch()}}
> * Add a new recipe that enables a fully managed Persistent watch
> * Create new Cache recipes that use the new Persistent watch recipe
> * Replace internal usages of TreeCache/PathChildrenCache/NodeCache with new
> cache recipe
> * Deprecate TreeCache/PathChildrenCache/NodeCache
> * Updated docs/tests/etc
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
