shayshim commented on a change in pull request #338: [CURATOR-549] Prep for 
Persistent Watchers by moving to ZK 3.6.0
URL: https://github.com/apache/curator/pull/338#discussion_r344515636
 
 

 ##########
 File path: 
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
 ##########
 @@ -620,6 +621,15 @@ ZooKeeper getZooKeeper() throws Exception
         return client.getZooKeeper();
     }
 
+    Object getZooKeeperAdmin() throws Exception
 
 Review comment:
   Only if the caller knows it has 3.5+ then it will be able to cast to 
ZooKeeperAdmin (which it currently has to anyways) and consequently use it. If 
it has 3.4 - it won't be able to cast - at compile time (no such class), which 
is safer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to