shayshim commented on a change in pull request #338: [CURATOR-549] Prep for
Persistent Watchers by moving to ZK 3.6.0
URL: https://github.com/apache/curator/pull/338#discussion_r344516054
##########
File path:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
##########
@@ -830,6 +840,12 @@ public boolean isZk34CompatibilityMode()
return zk34CompatibilityMode;
}
+ @Override
+ public boolean isZk35CompatibilityMode()
+ {
+ return !zk34CompatibilityMode &&
!Compatibility.hasPersistentWatchers();
Review comment:
BTW why do we need zk34CompatibilityMode as insatnce field? Couldn't we call
Compatibility.isZK34() instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
