Randgalt commented on a change in pull request #338: [CURATOR-549] Prep for
Persistent Watchers by moving to ZK 3.6.0
URL: https://github.com/apache/curator/pull/338#discussion_r344516177
##########
File path:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
##########
@@ -830,6 +840,12 @@ public boolean isZk34CompatibilityMode()
return zk34CompatibilityMode;
}
+ @Override
+ public boolean isZk35CompatibilityMode()
+ {
+ return !zk34CompatibilityMode &&
!Compatibility.hasPersistentWatchers();
Review comment:
I forget TBH. As I recall, I wanted users to be able to force 3.4 mode
regardless of the library. So, someone could use ZK 3.5 client library against
a 3.4 server. But this likely isn't important anymore. We should probably
consider removing 3.4 support altogether at some point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
