Randgalt commented on a change in pull request #338: [CURATOR-549] Prep for
Persistent Watchers by moving to ZK 3.6.0
URL: https://github.com/apache/curator/pull/338#discussion_r392675833
##########
File path:
curator-framework/src/main/java/org/apache/curator/framework/imps/ReconfigBuilderImpl.java
##########
@@ -268,7 +269,7 @@ public void processResult(int rc, String path, Object ctx,
byte[] bytes, Stat st
client.processBackgroundOperation(data, event);
}
};
- client.getZooKeeper().reconfig(joining, leaving, newMembers,
fromConfig, callback, backgrounding.getContext());
+ ((ZooKeeperAdmin)client.getZooKeeper()).reconfigure(joining,
leaving, newMembers, fromConfig, callback, backgrounding.getContext());
Review comment:
No - via the `ZookeeperFactory` clients can change which ZooKeeper class is
returned. In fact, I added `NonAdminZookeeperFactory` that returns the
non-admin ZooKeeper. Of course, clients will need to know they can't use the
reconfig APIs when this is done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
