shayshim commented on a change in pull request #343: [CURATOR-557]
ServiceCacheImpl does not close ExecutorService
URL: https://github.com/apache/curator/pull/343#discussion_r371451850
##########
File path:
curator-x-discovery/src/main/java/org/apache/curator/x/discovery/ServiceProviderBuilder.java
##########
@@ -52,6 +54,7 @@
* @param threadFactory factory to use
* @return this
*/
Review comment:
Please add to the Javadoc:
`* @deprecated use {@link #executorService(ExecutorService)} instead`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
