naude-r commented on a change in pull request #343: [CURATOR-557]
ServiceCacheImpl does not close ExecutorService
URL: https://github.com/apache/curator/pull/343#discussion_r371626468
##########
File path:
curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceProviderImpl.java
##########
@@ -43,13 +46,21 @@
private final ProviderStrategy<T> providerStrategy;
private final DownInstanceManager<T> downInstanceManager;
- public ServiceProviderImpl(ServiceDiscoveryImpl<T> discovery, String
serviceName, ProviderStrategy<T> providerStrategy, ThreadFactory threadFactory,
List<InstanceFilter<T>> filters, DownInstancePolicy downInstancePolicy)
+ public ServiceProviderImpl(ServiceDiscoveryImpl<T> discovery, String
serviceName, ProviderStrategy<T> providerStrategy, ThreadFactory threadFactory,
CloseableExecutorService executorService, List<InstanceFilter<T>> filters,
DownInstancePolicy downInstancePolicy)
Review comment:
done. constructor was made protected so that:
* it can be extended in future
* ServiceProviderBuilderImpl can access it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
