Randgalt commented on a change in pull request #345: [CURATOR-551] Fix Handle 
Holder new connection string
URL: https://github.com/apache/curator/pull/345#discussion_r377607990
 
 

 ##########
 File path: curator-client/src/main/java/org/apache/curator/HandleHolder.java
 ##########
 @@ -70,7 +61,16 @@ String  getConnectionString()
     String getNewConnectionString()
     {
         String helperConnectionString = (helper != null) ? 
helper.getConnectionString() : null;
-        return ((helperConnectionString != null) && 
!ensembleProvider.getConnectionString().equals(helperConnectionString)) ? 
helperConnectionString : null;
+        String ensembleProviderConnectionString = 
ensembleProvider.getConnectionString();
 
 Review comment:
   > whole flow of how things interact is very confusing
   
   Too true. What do we do? Should we attempt a more aggressive change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to