[GitHub] [curator] shayshim commented on a change in pull request #345: [CURATOR-551] Fix Handle Holder new connection string

[GitBox]

shayshim commented on a change in pull request #345: [CURATOR-551] Fix Handle 
Holder new connection string
URL: https://github.com/apache/curator/pull/345#discussion_r378038955
 
 

 ##########
 File path: curator-client/src/main/java/org/apache/curator/HandleHolder.java
 ##########
 @@ -70,7 +61,16 @@ String  getConnectionString()
     String getNewConnectionString()
     {
         String helperConnectionString = (helper != null) ? 
helper.getConnectionString() : null;
-        return ((helperConnectionString != null) && 
!ensembleProvider.getConnectionString().equals(helperConnectionString)) ? 
helperConnectionString : null;
+        String ensembleProviderConnectionString = 
ensembleProvider.getConnectionString();
 
 Review comment:
   > I'm OK with that. @shayshim ? Maybe you can both approve this PR when 
you're OK
   
   I agree  - better to continue refactor in different PR, dedicated for that

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services