Randgalt commented on a change in pull request #357: [CURATOR-525] Fix for
Zombie LOST Curator
URL: https://github.com/apache/curator/pull/357#discussion_r401329641
##########
File path:
curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionStateManager.java
##########
@@ -319,8 +319,18 @@ else if ( currentConnectionState == ConnectionState.LOST )
{
try
{
- // give ConnectionState.checkTimeouts() a chance to run, reset
ensemble providers, etc.
- client.getZookeeperClient().getZooKeeper();
+ if ( client.getZookeeperClient().isConnected() )
Review comment:
TBH - this makes me nervous. I worry about an infinite loop of resets. I'll
think about this some more before I merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
