Randgalt commented on a change in pull request #357: [CURATOR-525] Fix for
Zombie LOST Curator
URL: https://github.com/apache/curator/pull/357#discussion_r401813803
##########
File path:
curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionStateManager.java
##########
@@ -319,8 +319,18 @@ else if ( currentConnectionState == ConnectionState.LOST )
{
try
{
- // give ConnectionState.checkTimeouts() a chance to run, reset
ensemble providers, etc.
- client.getZookeeperClient().getZooKeeper();
+ if ( client.getZookeeperClient().isConnected() )
Review comment:
Much of that backend code needs to be reconsidered. If you're interested it
would be a great project. I could help. If, I find the time, I'll rework some
of it. For example, the ConnectionState code belongs in the client code, not
the framework code. Pulling all that out and re-writing it directly in the
client module would simplify things and give us an opportunity to remove some
races due to their being two different threads (ZK's and Curator's).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
