Randgalt commented on a change in pull request #367:
URL: https://github.com/apache/curator/pull/367#discussion_r440971288
##########
File path:
curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceCacheImpl.java
##########
@@ -78,7 +79,7 @@ private static ExecutorService
convertThreadFactory(ThreadFactory threadFactory)
this.discovery = discovery;
- String path = discovery.pathForName(name);
+ path = discovery.pathForName(name);
Review comment:
If pushing it down fixes it then it is a regression. I'm surprised we
don't have a test for this. We can get a new version out if needed. However, it
will only be an issue with ZK 3.6 - pre-3.6 PathChildrenCache is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
