eolivelli commented on a change in pull request #367:
URL: https://github.com/apache/curator/pull/367#discussion_r442275526
##########
File path:
curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceCacheImpl.java
##########
@@ -78,7 +79,7 @@ private static ExecutorService
convertThreadFactory(ThreadFactory threadFactory)
this.discovery = discovery;
- String path = discovery.pathForName(name);
+ path = discovery.pathForName(name);
Review comment:
I see this problem with ZK 3.5.7 not with 3.6.
btw @Randgalt I see that CuratorCacheListener does not hold a reference to
the root path, and it does not hold any reference to the CuratorCache.
I cannot introduce such reference, because it will be an incompatible change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]