jira-importer commented on issue #554: URL: https://github.com/apache/curator/issues/554#issuecomment-2604695369
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=randgalt";>randgalt</a>:</i> <p>My initial view of the change is good. However, I'd like to see more tests. For example, processChildren() can cause a getDataAndStat() and then an internalRefresh(). This smells like a potential race, but I'd need to prove it.</p> <p>So, please provide some more tests. Maybe create a new test class dedicated to testing DescendantHandlingMode.ALL_DESCENDANTS</p> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
