jira-importer commented on issue #554: URL: https://github.com/apache/curator/issues/554#issuecomment-2604695417
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=dragonsinth";>dragonsinth</a>:</i> <p>It's possible I'm missing something serious, but in the copy of the patch I got, the new "rebuild(String root)" is not being called anywhere, and refresh is only getting called on the root path.</p> <ul class="alternate" type="square"> <li>I don't see where child watches are getting setup on anything other than the root node; you'd need to add a child watch to every node in the entire tree. testCacheWholeTree() is failing because it never gets a creation event for any nested subnodes, which is as I would expect due to not setting up child listeners on children.</li> </ul> <ul class="alternate" type="square"> <li>I would expect that RefreshOperation would need a new "path" field to say what part of the tree needs to be refreshed when some subnode changes.</li> </ul> <ul class="alternate" type="square"> <li>processChildren() would need some serious kung-fu to handle currentData updates on subnodes. For example, if you got an update that node "test/1" has a child "2", the current code would remove all data for all nodes in the entire tree except for "test/1/2"; it needs to remove only children of "test/1". This would be inefficient given that currentData is a flat hashmap rather than a tree-like structure where an entire subtree could be pruned in one go.</li> </ul> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
