andymc12 commented on a change in pull request #323: Handle @Priority on
ExceptionMappers
URL: https://github.com/apache/cxf/pull/323#discussion_r146368406
##########
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/provider/ProviderFactory.java
##########
@@ -858,7 +858,7 @@ private static int compareCustomStatus(ProviderInfo<?> p1,
ProviderInfo<?> p2) {
return result;
}
- private static int comparePriorityStatus(Class<?> cl1, Class<?> cl2) {
+ static int comparePriorityStatus(Class<?> cl1, Class<?> cl2) {
Review comment:
I prefer to limit visibility as much as possible. In this case, the only
caller of the `comparePriorityStatus` method is in the same package, so
default/package visibility is more limiting than `protected` since it does not
allow visibility to sub-classes outside of this package. If other classes
(sub-classes or otherwise) need to call this method, then I think we could
change the visibility to `protected` or `public` if necessary. Thanks for the
review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
