andymc12 commented on a change in pull request #323: Handle @Priority on
ExceptionMappers
URL: https://github.com/apache/cxf/pull/323#discussion_r146604843
##########
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/provider/ProviderFactory.java
##########
@@ -858,7 +858,7 @@ private static int compareCustomStatus(ProviderInfo<?> p1,
ProviderInfo<?> p2) {
return result;
}
- private static int comparePriorityStatus(Class<?> cl1, Class<?> cl2) {
+ static int comparePriorityStatus(Class<?> cl1, Class<?> cl2) {
Review comment:
I must be misunderstanding something. This is a new method that I added
last week - originally at private visibility because only `ProviderFactory`
needed to access it - and to be consistent with the `compareCustomStatus`
method directly above it. I removed the `private` modifier so that
`ServerProviderFactory` (subclass in the same package) could also access it -
to sort ExceptionMappers.
Does some other code need to access this method? The unit tests do not call
it directly (thus they don't need visibility), but the method is covered by
tests that verify the proper sorting of different types of providers. There
shouldn't be anything else that is currently calling this method since it is so
new. If future work in a different package needs to call this method, then
that work should be free to change the visibility as necessary. Am I missing
some other use case? Thanks again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
