rmannibucau commented on a change in pull request #683:
URL: https://github.com/apache/cxf/pull/683#discussion_r454807050



##########
File path: 
rt/rs/microprofile-client/src/main/java/org/apache/cxf/microprofile/client/MicroProfileClientFactoryBean.java
##########
@@ -63,7 +66,7 @@ public 
MicroProfileClientFactoryBean(MicroProfileClientConfigurableImpl<RestClie
         super(new MicroProfileServiceFactoryBean());
         this.configuration = configuration.getConfiguration();
         this.comparator = 
MicroProfileClientProviderFactory.createComparator(this);
-        this.executorService = executorService;
+        this.executorService = (executorService == null) ? 
defaultExecutorService() : executorService; 

Review comment:
       maybe make it lazy to not create it (forkjoin common pool) if the app 
does not use it and the client for its lifecycle?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to