rmannibucau commented on a change in pull request #683:
URL: https://github.com/apache/cxf/pull/683#discussion_r456239356
##########
File path:
rt/rs/microprofile-client/src/main/java/org/apache/cxf/microprofile/client/MicroProfileClientFactoryBean.java
##########
@@ -63,7 +66,7 @@ public
MicroProfileClientFactoryBean(MicroProfileClientConfigurableImpl<RestClie
super(new MicroProfileServiceFactoryBean());
this.configuration = configuration.getConfiguration();
this.comparator =
MicroProfileClientProviderFactory.createComparator(this);
- this.executorService = executorService;
+ this.executorService = (executorService == null) ?
defaultExecutorService() : executorService;
Review comment:
Yep, was not a good phrasing choice. Fact is getting triggers the common
(var) instantiation which brings a lot of work - for nothing in some cases and
that's what I'd like to avoid.
Having a facade enables to just load a class and do a new without
dependencies (static init) and speed up the startup.
We faced it in openwebbeans and this is why we have that wrapper
https://github.com/apache/openwebbeans/blob/9b04c5e906294bcad7c61f30b5c5fcc8956b2f17/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java#L954.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
