rmannibucau commented on a change in pull request #721:
URL: https://github.com/apache/cxf/pull/721#discussion_r532523229
##########
File path:
rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/WrapperNamespaceClassGeneratorTest.java
##########
@@ -119,5 +126,170 @@ public void testForXmlList() throws Exception {
assertTrue("The generated response wrapper class is not correct",
bout.toString().contains(expected));
}
+ public class CustomClassLoader extends ClassLoader {
Review comment:
E2e = your write an app, setup a maven plugin execution and get
pregenerated runtime. This is the story we want to enable ;).
I understand the test nightmare but we must not design an api for tests IMHO
and from all other products doing this kind of generation we know it is not
needed so let's keep the SPI clean and we will clean up the impl later. If you
need to expose this internal it means the spi is not at the right point maybe -
but think the classloader itself shoude the spi in this particular case.
If you find a failling test i can run easily, i can have a look later this
week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
