rmannibucau commented on a change in pull request #721: URL: https://github.com/apache/cxf/pull/721#discussion_r533241812
########## File path: core/src/main/java/org/apache/cxf/common/spi/GeneratedClassClassLoader.java ########## @@ -0,0 +1,118 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.cxf.common.spi; + +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; +import java.util.logging.Logger; + +import org.apache.cxf.Bus; +import org.apache.cxf.common.classloader.ClassLoaderUtils; +import org.apache.cxf.common.logging.LogUtils; +import org.apache.cxf.common.util.StringUtils; + +public class GeneratedClassClassLoader { + private static final Logger LOG = LogUtils.getL7dLogger(ClassLoaderProxyService.class); + protected final Bus bus; + + public GeneratedClassClassLoader(Bus bus) { + this.bus = bus; + } + protected Class<?> findClass(String className, Class<?> callingClass) { + ClassLoader cl = getClassLoader(); + try { + return cl.loadClass(className); + } catch (ClassNotFoundException e) { + //ignore and try with other class loader + } + try { + return ClassLoaderUtils.loadClass(className, callingClass); + } catch (ClassNotFoundException e) { + LOG.fine("Failed to load class :" + e.toString()); + } + return null; + } + public TypeHelperClassLoader getClassLoader() { + TypeHelperClassLoader loader = bus.getExtension(TypeHelperClassLoader.class); + if (loader == null) { + loader = bus.getExtension(TypeHelperClassLoader.class); + if (loader == null) { + ClassLoader parent = bus.getExtension(ClassLoader.class); + if (parent == null) { + parent = Thread.currentThread().getContextClassLoader(); + } + loader = new TypeHelperClassLoader(parent); + bus.setExtension(loader, TypeHelperClassLoader.class); + } + } + return loader; + } + + public void restore(ClassGeneratorCapture capture) { Review comment: You dont have to expose the map, you can provide a getter from the classloader (because it is what these classes do at the end) and it is convenient for libs like yours which will then just dump everything from there but it is not required. Your lib can also extend it and dump it on the fly. The getter does not cost anything and is a simple option but forcing a subclass is not that complicated too. Also note that the runtime mode does NOT use the map of bytes, it is the capture mode, the runtime mode just loadClass directly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
