marcingrzejszczak opened a new pull request, #1346: URL: https://github.com/apache/cxf/pull/1346
This PR adds support for Micrometer Observation instrumentation of Apache CXF. NOTE: This PR is heavily influenced by Brave's implementation. Dependencies - Adds micrometer tracing - Adds zipkin sender CXF metrics project - Now also does tracing (TODO: maybe this should be done in a separate module?) - Adds dependency on `rt-management` since metrics will now also be related to tracing - Adds dependency to Micrometer Observation - Is a copy of the Brave Tracing module but adopted to Micrometer Observation API - Uses low and high cardinality tags basing on OpenTelemetry Semantic Conventions for RPC and HTTP (JaxRs) from 19.07.2023. VERY IMPORTANT: This doesn't mean that this project is OTel Semantic Convention compliant!!! - Uses `ObservationDocumentation` that using https://micrometer.io/docs/observation#_documentation_generation could generate asciidoctor documentation of observability data Spring Boot - adds `MicrometerObservationAutoConfiguration` that registers `Feature`s as beans Tests - reused existing Brave tests with Micrometer Observation, altered existing tagging and naming defaults to make the test pass with Brave tagging and naming defaults - reused existing Boot tests to additionally assert observation based metrics and traces TODO ? : - maybe the code shouldn't be in CXF metrics module but a completely separate one? - add Javadocs? - add documentation - where should it be added? Fixes https://issues.apache.org/jira/browse/CXF-8817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
