reta commented on code in PR #1346: URL: https://github.com/apache/cxf/pull/1346#discussion_r1272910129
########## integration/tracing/tracing-micrometer/pom.xml: ########## @@ -0,0 +1,103 @@ +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <artifactId>cxf-integration-tracing-micrometer</artifactId> + <packaging>bundle</packaging> + <name>Apache CXF Observability using Micrometer Observation</name> + <description>Apache CXF Observability using Micrometer Observation</description> + <url>https://cxf.apache.org</url> + <parent> + <groupId>org.apache.cxf</groupId> + <artifactId>cxf-parent</artifactId> + <version>4.0.3-SNAPSHOT</version> + <relativePath>../../../parent/pom.xml</relativePath> + </parent> + + <properties> + <cxf.module.name>org.apache.cxf.tracing.micrometer</cxf.module.name> + <cxf.osgi.export> + org.apache.cxf.tracing, + org.apache.cxf.tracing.micrometer, + org.apache.cxf.tracing.micrometer.jaxrs + </cxf.osgi.export> + </properties> + + <dependencies> + <dependency> + <groupId>jakarta.xml.ws</groupId> + <artifactId>jakarta.xml.ws-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.cxf</groupId> + <artifactId>cxf-core</artifactId> + <version>${project.version}</version> + </dependency> + <dependency> + <groupId>org.apache.cxf</groupId> + <artifactId>cxf-rt-management</artifactId> + <version>${project.version}</version> + </dependency> + + <dependency> Review Comment: I think these two artifacts shouldn't be optional since they are always required for this integration, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
