reta commented on code in PR #1340:
URL: https://github.com/apache/cxf/pull/1340#discussion_r1276905543
##########
integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/OpenTelemetryTracerUtils.java:
##########
@@ -0,0 +1,17 @@
+package org.apache.cxf.tracing.opentelemetry;
+
+import io.opentelemetry.api.OpenTelemetry;
+import io.opentelemetry.api.trace.Tracer;
+import org.apache.cxf.version.Version;
+
+public final class OpenTelemetryTracerUtils {
Review Comment:
I would be inclined to drop this class and use constant for default name but
also provide the way to specify the tracer name (fe `BraveFeature` follows this
approach). Please let me know what do you think, I am happy to take that as
post merge action, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
