mederel commented on code in PR #1340:
URL: https://github.com/apache/cxf/pull/1340#discussion_r1277354863
##########
integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/OpenTelemetryTracerUtils.java:
##########
@@ -0,0 +1,17 @@
+package org.apache.cxf.tracing.opentelemetry;
+
+import io.opentelemetry.api.OpenTelemetry;
+import io.opentelemetry.api.trace.Tracer;
+import org.apache.cxf.version.Version;
+
+public final class OpenTelemetryTracerUtils {
Review Comment:
I removed the utility class, and added new constructors with an
instrumentationName argument. It defaults to a constant "org.apache.cxf". I
remove all notions of instrumentation versions (looking in
opentelemetry-java-instrumentation, I see that it is not always set). Custom
names are tested in the systests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
