reta commented on PR #1777: URL: https://github.com/apache/cxf/pull/1777#issuecomment-2043962585
> @reta Thanks for improving this ! Just some minor comments: Thanks a lot @jimma for taking a look > * Do we need to limit the cache size number to make sure the bad usage doesn't consumes all memory ? > Certainly, I will add reasonable guards to the cache > * For the cache implementation, does the ConcunrrentHashMap with the client policy+ssl parameter as the key work for this ? I am not sure if this is better for the performance or can simplify something . I was thinking about that. `ConcurrentHashMap` would need a bit more work and require larger memory footprint, I am not sure it worth it (at the moment). But I will experiment for sure, I am working on test cases right now that would help us estimate the cache lookup overhead and its heap consumption. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
