jimma commented on PR #1777: URL: https://github.com/apache/cxf/pull/1777#issuecomment-2065712077
> > @reta This looks good. I'll try to run some performance tests for this change and it looks this change can improve the client performance too next week. > > Thanks @jimma ! To be fair, the change shouldn't bring improvements (nor regressions) on the performance profile but the heap / threads footprint - definitely. Do you want me to hold off the merge or we could do these tests along the way? thanks! I thought less client creation and less threads would impact performance, but it isn't. I already ran the tests and result as you expected: this change didn't bring improvement. I already finished the tests and you can go ahead to merge this change. For the httpclient executor, should it set to some shared new fixed size thread pool like cpu processor count *2 by default instead of using JDK's `Executors.newCachedThreadPool()` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
