reta commented on code in PR #2664:
URL: https://github.com/apache/cxf/pull/2664#discussion_r2430061425
##########
rt/features/metrics/src/main/java/org/apache/cxf/metrics/micrometer/MicrometerMetricsProvider.java:
##########
@@ -61,7 +61,13 @@ public MicrometerMetricsProvider(MeterRegistry registry,
*/
@Override
public MetricsContext createEndpointContext(Endpoint endpoint, boolean
asClient, String clientId) {
- return null;
+ if (asClient) {
+ return null;
Review Comment:
Thanks @ffang , should we cover client as well?
```suggestion
return new MicrometerClientMetricsContext(registry,
tagsProvider, timedAnnotationProvider, tagsCustomizers,
micrometerMetricsProperties.getClientRequestsMetricName());;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
