ffang commented on code in PR #2664:
URL: https://github.com/apache/cxf/pull/2664#discussion_r2430153354


##########
rt/features/metrics/src/main/java/org/apache/cxf/metrics/micrometer/MicrometerMetricsProvider.java:
##########
@@ -61,7 +61,13 @@ public MicrometerMetricsProvider(MeterRegistry registry,
      */
     @Override
     public MetricsContext createEndpointContext(Endpoint endpoint, boolean 
asClient, String clientId) {
-        return null;
+        if (asClient) {
+            return null;

Review Comment:
   Hi @reta ,
   
   No IMO. Because on the client side the the BindingOperationInfo is always 
available from the service model(java class or wsdl), so can always create the 
expected OperationContext.
   
   Thanks!
   Freeman 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to