ppalaga commented on code in PR #2683:
URL: https://github.com/apache/cxf/pull/2683#discussion_r2462648631
##########
integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/AbstractOpenTelemetryClientProvider.java:
##########
@@ -141,7 +141,7 @@ protected void stopTraceSpan(final
TraceScopeHolder<TraceScope> holder, final Th
span.setStatus(StatusCode.ERROR);
if (ex != null) {
- span.recordException(ex,
Attributes.of(ExceptionAttributes.EXCEPTION_ESCAPED, true));
+ span.recordException(ex);
Review Comment:
`ExceptionAttributes.EXCEPTION_ESCAPED` was removed in
opentelemetry-semconv-incubating 1.30.0-alpha. Its docs said since longer that
it was deprecated and "It’s no longer recommended to record exceptions that are
handled and do not escape the scope of a span.", so just removing the
attribute, given the hardcoded `true`, should be fine - see
https://opentelemetry.io/docs/specs/semconv/registry/attributes/exception/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
