reta commented on code in PR #2683:
URL: https://github.com/apache/cxf/pull/2683#discussion_r2462729513
##########
integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/AbstractOpenTelemetryClientProvider.java:
##########
@@ -141,7 +141,7 @@ protected void stopTraceSpan(final
TraceScopeHolder<TraceScope> holder, final Th
span.setStatus(StatusCode.ERROR);
if (ex != null) {
- span.recordException(ex,
Attributes.of(ExceptionAttributes.EXCEPTION_ESCAPED, true));
+ span.recordException(ex);
Review Comment:
Yes, we know about this change and it is planned for 4.2 (see please
https://github.com/apache/cxf/pull/2473/files#diff-c7f236ca73be741018e92028d79517c03d1bbc27fe58a1b8dd4258bb4a80b38eL144).
I think we could incorporate that into 4.0.x line as well but without bringing
`1.32.0` (we broke a few downstream dependencies in the past), thanks @ppalaga
##########
integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/AbstractOpenTelemetryClientProvider.java:
##########
@@ -141,7 +141,7 @@ protected void stopTraceSpan(final
TraceScopeHolder<TraceScope> holder, final Th
span.setStatus(StatusCode.ERROR);
if (ex != null) {
- span.recordException(ex,
Attributes.of(ExceptionAttributes.EXCEPTION_ESCAPED, true));
+ span.recordException(ex);
Review Comment:
Yes, we know about this change and it is planned for 4.2 (see please
https://github.com/apache/cxf/pull/2473/files#diff-c7f236ca73be741018e92028d79517c03d1bbc27fe58a1b8dd4258bb4a80b38eL144).
I think we could incorporate that into 4.1.x line as well but without bringing
`1.32.0` (we broke a few downstream dependencies in the past), thanks @ppalaga
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
